Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NCSDK-30809: Restructure suit_plat_fetch #19851

Merged
merged 2 commits into from
Jan 27, 2025
Merged

NCSDK-30809: Restructure suit_plat_fetch #19851

merged 2 commits into from
Jan 27, 2025

Conversation

tomchy
Copy link
Contributor

@tomchy tomchy commented Jan 10, 2025

No description provided.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 10, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 10, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: a643479eefd03801b1e6c20a5185d7af4bc6ffc7

more details

sdk-nrf:

PR head: a643479eefd03801b1e6c20a5185d7af4bc6ffc7
merge base: 3e7e7b90ff2e845e3e6870c84ba91d6998d021db
target head (main): 3e7e7b90ff2e845e3e6870c84ba91d6998d021db
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7) 
subsys
│  ├── suit
│  │  ├── platform
│  │  │  ├── app
│  │  │  │  ├── src
│  │  │  │  │  │ suit_plat_fetch_app_specific.c
│  │  │  ├── include
│  │  │  │  │ suit_plat_fetch_domain_specific.h
│  │  │  ├── sdfw
│  │  │  │  ├── src
│  │  │  │  │  │ suit_plat_fetch_sdfw_specific.c
│  │  │  ├── src
│  │  │  │  │ suit_plat_fetch.c
tests
│  ├── subsys
│  │  ├── suit
│  │  │  ├── unit
│  │  │  │  ├── app_specific
│  │  │  │  │  ├── suit_plat_fetch_app
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c
│  │  │  │  ├── mocks
│  │  │  │  │  │ CMakeLists.txt

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@tomchy tomchy marked this pull request as ready for review January 10, 2025 15:28
@tomchy tomchy requested review from a team as code owners January 10, 2025 15:28
@tomchy tomchy force-pushed the feature/suit/NCSDK-NONE_Rewrite_fetchers branch from 3b1f00e to 7d5ba1e Compare January 10, 2025 15:28
@ahasztag ahasztag self-requested a review January 13, 2025 08:12
@tomchy tomchy force-pushed the feature/suit/NCSDK-NONE_Rewrite_fetchers branch 2 times, most recently from 50d82dd to f660238 Compare January 20, 2025 16:25
@tomchy tomchy force-pushed the feature/suit/NCSDK-NONE_Rewrite_fetchers branch from f660238 to fe417aa Compare January 21, 2025 11:11
tomchy added 2 commits January 27, 2025 12:12
@tomchy
suit: Split fetch implementation
973bbe0 
Split suit_plat_fetch implementation into app-specific and sdfw-specific
parts.

Ref: NCSDK-30809

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy
tests: Align suit_plat_fetch APP tests
a643479 
Remove tests that verify common implementation.

Ref: NCSDK-30809

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy force-pushed the feature/suit/NCSDK-NONE_Rewrite_fetchers branch from fe417aa to a643479 Compare January 27, 2025 11:13
@tomchy tomchy merged commit 10e197e into nrfconnect:main Jan 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylwesterKonczyk SylwesterKonczyk SylwesterKonczyk approved these changes

@nordicjm nordicjm nordicjm approved these changes

@ahasztag ahasztag ahasztag approved these changes

@adsz-nordic adsz-nordic adsz-nordic approved these changes

@robertstypa robertstypa Awaiting requested review from robertstypa

@kszromek-nordic kszromek-nordic Awaiting requested review from kszromek-nordic

@nordic-mik7 nordic-mik7 Awaiting requested review from nordic-mik7

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomchy @NordicBuilder @SylwesterKonczyk @nordicjm @ahasztag @adsz-nordic